On Mon, Aug 26, 2019 at 02:52:53AM -0700, Christoph Hellwig wrote: > On Mon, Aug 26, 2019 at 01:01:30PM +0800, Murphy Zhou wrote: > > Since xfsprogs commit > > 32dd7d9c xfs: remove various bulk request typedef usage > > > > Some typedef _t types have been removed, so did in header files. > > I wonder if we need to add them back to xfsprogs to not break other > tools using the header. But independent of that I think killing > them in xfsdump is good. > > > typedef char *(*gwbfp_t)(void *contextp, size_t wantedsz, size_t *szp); > > typedef int (*wfp_t)(void *contextp, char *bufp, size_t bufsz); > > +typedef struct xfs_bstat xfs_bstat_t; > > +typedef struct xfs_inogrp xfs_inogrp_t; > > +typedef struct xfs_fsop_bulkreq xfs_fsop_bulkreq_t; > > I think we just need to stop using the typedefs, as this would break > a compile with the old xfsprogs headers. So we need to add typedefs back to xfsprogs to not breaking others. And kill it in xfsdump. Are there tools using xfsdump's libs and headers ? Breaking them? Thanks, m
