On 8/22/19 4:05 AM, Ian Kent wrote: > On Wed, 2019-08-21 at 09:52 -0500, Eric Sandeen wrote: >> On 6/23/19 9:58 PM, Ian Kent wrote: >>> The new mount-api uses an array of struct fs_parameter_spec for >>> parameter parsing, create this table populated with the xfs mount >>> parameters. >>> >>> The new mount-api table definition is wider than the token based >>> parameter table and interleaving the option description comments >>> between each table line is much less readable than adding them to >>> the end of each table entry. So add the option description comment >>> to each entry line even though it causes quite a few of the entries >>> to be longer than 80 characters. >>> >>> Signed-off-by: Ian Kent <raven@xxxxxxxxxx> >> >> Ian, I saw hints about a V2 in replies, is that still in the works? > > I have a v2 that should address the comments made on the initial > post. > > My reluctance to post the v2 is because the series uses a patch > that's currently sitting in linux-next and that will cause a > conflict if the series is accepted. > > I'm thinking about doing an RFC post with that patch included > and a caution about the possible conflict. That should be fine, just let everyone know what the patchset is based on and we can do another round of review & sort out the dependencies as needed, I think. Thanks -Eric > Not sure yet, I've only just yesterday been able to successfully > run xfstests on a kernel with the changes so deciding what to do > next is upon me now, ;)
