On Thu, Aug 22, 2019 at 02:49:05PM +1000, Dave Chinner wrote: > On Thu, Aug 22, 2019 at 10:50:02AM +0800, Ming Lei wrote: > > It isn't correct to blk_rq_aligned() here because 'len' has to be logical block > > size aligned, instead of DMA aligned only. Even if len would have to be a multiple of the sector size, that doesn't mean calling blk_rq_aligned would be incorrect, just possibly not catching all issues. But as Dave outlined I don't think it is a problem in any way.