On Tue, Aug 13, 2019 at 12:18:04AM +0200, Thomas Deutschmann wrote:
> On 2019-08-12 23:44, Dave Chinner wrote:
> >> That's not the correct way to reproduce. It's really important to
> >> _export_ the variable to trigger the problem and _this_ is a problem in
> >> xfsprogs' build system.
> > Which means you are overriding the LDFLAGS set by configure when
> > you _run make_, not just telling configure to use those LDFLAGS.
> >
> > That's why _make_ is getting screwed up - it is doing exactly what
> > you are telling it to do, and that is to overrides every occurrence
> > of LDFLAGS with your exported options rather than using the correct
> > set configure calculated and specified.
> >
> > Exporting your CFLAGS and LDFLAGS is the wrong thing to doing
> > - they should only ever be passed to the configure invocation and
> > not remain to pollute the build environment after you've run
> > configure.
>
> I disagree with the conclusion. LDFLAGS in build environment shouldn't
> cause any problems, especially when you are using a build system:
>
> Normally, configure will get the value and the Makefiles will use the
> value _from_ configure... but using configure _and_ reading _and adding_
> values from environment _in addition_ seems to be wrong.
<sigh>
xfsprogs-2.7.18 (16 May 2006)
- Fixed a case where xfs_repair was reporting a valid used
block as a duplicate during phase 4.
- Fixed a case where xfs_repair could incorrectly flag extent
b+tree nodes as corrupt.
- Portability changes, get xfs_repair compiling on IRIX.
- Parent pointer updates in xfs_io checker command.
- Allow LDFLAGS to be overridden, for Gentoo punters.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Back in 2006 we added the ability for LDFLAGS to be overriden
specifically because Gentoo users wanted it.
> So you either use a build system or you don't.
Yup, but Gentoo wanted it both ways, and so we gave them that
capability. And now you're complaining that Gentoo users can shoot
themselves in the foot with it.... :/
Just pass your special CFLAGS/LDFLAGS to configure like the rest of
the world does and everything will work correctly.
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
