On Mon, Aug 12, 2019 at 07:57:27PM +0900, Tetsuo Handa wrote: > On 2019/08/03 7:21, Luis Chamberlain wrote: > >> I'm pretty sure this didn't solve the underlying stale data exposure > >> problem, which might be why you think this is "opaque". It fixes a bug > >> that causes data writeback failure (which was the exposure vector this > >> time) but I think the ultimate fix for the exposure problem are the two > >> patches I linked to quite a ways back in this discussion.... > >> > >> --D > >> > >> https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/commit/?id=bd012b434a56d9fac3cbc33062b8e2cd6e1ad0a0 > >> https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/commit/?id=adcf7c0c87191fd3616813c8ce9790f89a9a8eba > > > > Got it, thanks! Even with this, I still think the current commit could > > say a bit a more about the effects of not having this patch applied. > > What are the effects of say having the above two patches applied but not > > the one being submitted now? > > Is this patch going to be applied as-is? Or, someone have a plan to > rewrite the changelog? The first one, since the patch eliminates a vector to the writeback race problem but does not iself solve the race. --D
