Hi all, This set is a subset of a larger series for parent pointers. Delayed attributes allow attribute operations (set and remove) to be logged and committed in the same way that other delayed operations do. This will help break up more complex operations when we later introduce parent pointers which can be used in a number of optimizations. Since delayed attributes can be implemented as a stand alone feature, I've decided to subdivide the set to help make it more manageable. Changes since v2: Patches 6 through 17 are new and focus mostly on refactoring the attribute set and remove operations. Since delayed operations can not be handling transactions, to goal of the refactoring is to factor up the transaction specific code as much as possible while modularizing the remaining code into helper functions that we can reuse for our new delayed attr routines. Patch 15 then adds a new set of xfs_attr_da* routines that return EAGAIN when a new transaction is needed. Patch 14 adds a new struct xfs_delay_context which these new routine will use to stash local variables or other information they need to more or less pickup where they left off. I've also made the corresponding updates to the user space side, and added a new test case to xfstests as well. I'm still getting an error about busy inodes after the journal replay, but I figure theres plenty here to people to review while I work on that. Question, comment and feedback appreciated! Thanks all! Allison Allison Collins (13): xfs: Replace attribute parameters with struct xfs_name xfs: Factor out new helper functions xfs_attr_rmtval_set xfs: Factor up trans handling in xfs_attr3_leaf_flipflags xfs: Factor out xfs_attr_leaf_addname helper xfs: Factor up commit from xfs_attr_try_sf_addname xfs: Factor up trans roll from xfs_attr3_leaf_setflag xfs: Add xfs_attr3_leaf helper functions xfs: Factor out xfs_attr_rmtval_remove_value xfs: Factor up trans roll in xfs_attr3_leaf_clearflag xfs: Add delay context to xfs_da_args xfs: Add delayed attribute routines xfs: Roll delayed attr operations by returning EAGAIN xfs: Enable delayed attributes Allison Henderson (5): xfs: Remove all strlen in all xfs_attr_* functions for attr names. xfs: Set up infastructure for deferred attribute operations xfs: Add xfs_attr_set_deferred and xfs_attr_remove_deferred xfs: Add xfs_has_attr and subroutines xfs: Add delayed attributes error tag fs/xfs/Makefile | 2 +- fs/xfs/libxfs/xfs_attr.c | 1145 ++++++++++++++++++++++++++++++++++----- fs/xfs/libxfs/xfs_attr.h | 49 +- fs/xfs/libxfs/xfs_attr_leaf.c | 167 ++++-- fs/xfs/libxfs/xfs_attr_leaf.h | 4 + fs/xfs/libxfs/xfs_attr_remote.c | 98 +++- fs/xfs/libxfs/xfs_attr_remote.h | 5 +- fs/xfs/libxfs/xfs_da_btree.h | 23 + fs/xfs/libxfs/xfs_defer.c | 1 + fs/xfs/libxfs/xfs_defer.h | 3 + fs/xfs/libxfs/xfs_errortag.h | 4 +- fs/xfs/libxfs/xfs_log_format.h | 44 +- fs/xfs/libxfs/xfs_types.h | 1 + fs/xfs/scrub/common.c | 2 + fs/xfs/xfs_acl.c | 26 +- fs/xfs/xfs_attr_item.c | 804 +++++++++++++++++++++++++++ fs/xfs/xfs_attr_item.h | 102 ++++ fs/xfs/xfs_attr_list.c | 1 + fs/xfs/xfs_error.c | 3 + fs/xfs/xfs_ioctl.c | 21 +- fs/xfs/xfs_ioctl32.c | 2 + fs/xfs/xfs_iops.c | 10 +- fs/xfs/xfs_log.c | 4 + fs/xfs/xfs_log_recover.c | 174 ++++++ fs/xfs/xfs_ondisk.h | 2 + fs/xfs/xfs_trans.h | 4 +- fs/xfs/xfs_xattr.c | 20 +- 27 files changed, 2504 insertions(+), 217 deletions(-) create mode 100644 fs/xfs/xfs_attr_item.c create mode 100644 fs/xfs/xfs_attr_item.h -- 2.7.4
