> > > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
> > > index b485190b7ecd..18a798e9076b 100644
> > > --- a/fs/xfs/xfs_iops.c
> > > +++ b/fs/xfs/xfs_iops.c
> > > @@ -1113,6 +1113,11 @@ xfs_vn_fiemap(
> > > struct fiemap_extent_info *fieinfo)
> > > {
> > > int error;
> > > + struct xfs_inode *ip = XFS_I(inode);
> >
> > Would you mind fixing the indentation to match usual xfs style?
> >
> > > +
> > > + if (fieinfo->fi_flags & FIEMAP_KERNEL_FIBMAP)
> > > + if (xfs_is_reflink_inode(ip) || XFS_IS_REALTIME_INODE(ip))
> > > + return -EINVAL;
> >
> > The xfs part looks ok to me.
>
> No it doesn't. This check ought to be xfs_is_cow_inode() to match the
> code being removed in the last patch:
>
> if ((fieinfo->fi_flags & FIEMAP_KERNEL_FIBMAP) &&
> (xfs_is_cow_inode(ip) || XFS_IS_REALTIME_INODE(ip)))
> return -EINVAL;
>
Agreed, will fix
> > --D
> >
--
Carlos
