Hi Darrick. > > + return error; > > + > > + block = ur_block; > > + error = bmap(inode, &block); > > + > > + if (error) > > + ur_block = 0; > > + else > > + ur_block = block; > > What happens if ur_block > INT_MAX? Shouldn't we return zero (i.e. > error) instead of truncating the value? Maybe the code does this > somewhere else? Here seemed like the obvious place for an overflow > check as we go from sector_t to int. > The behavior should still be the same. It will get truncated, unfortunately. I don't think we can actually change this behavior and return zero instead of truncating it. > --D > > > + > > + error = put_user(ur_block, p); > > + > > + return error; > > } > > > > /** > > -- > > 2.20.1 > > -- Carlos
