On Wed, Jul 31, 2019 at 06:43:10PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Check that the new v5 bulkstat commands do everything the old one do, > and then make sure the new functionality actually works. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > --- > .gitignore | 1 > src/Makefile | 2 > src/bulkstat_null_ocount.c | 61 +++++++++ > tests/xfs/744 | 215 ++++++++++++++++++++++++++++++++ > tests/xfs/744.out | 297 ++++++++++++++++++++++++++++++++++++++++++++ > tests/xfs/745 | 47 +++++++ > tests/xfs/745.out | 2 > tests/xfs/group | 2 > 8 files changed, 626 insertions(+), 1 deletion(-) > create mode 100644 src/bulkstat_null_ocount.c > create mode 100755 tests/xfs/744 > create mode 100644 tests/xfs/744.out > create mode 100755 tests/xfs/745 > create mode 100644 tests/xfs/745.out > > ... > diff --git a/tests/xfs/group b/tests/xfs/group > index 270d82ff..ef0cf92c 100644 > --- a/tests/xfs/group > +++ b/tests/xfs/group > @@ -506,3 +506,5 @@ > 506 auto quick health > 507 clone > 508 auto quick quota > +744 auto ioctl quick > +745 auto ioctl quick > One quick note that xfs/744 runs in ~68 seconds in my (low resource) test VM. Not a problem in and of itself, but it seems slightly long for the quick group. Can somebody remind me of the quick group criteria? FWIW if I kick off a quick group run, the first 10-15 tests complete in 10s or so or less with the exception of generic/013, which takes over a minute. So perhaps anything under a minute or so is fine..? Either way, that can be easily changed on merge if appropriate: Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>