On Thu, Jul 25, 2019 at 10:53:46AM -0700, Darrick J. Wong wrote: > Explicitly initialize the onstack structures to zero so we don't leak > kernel memory into userspace when converting the in-core inumbers > structure to the v1 inogrp ioctl structure. Add a comment about why we > have to use memset to ensure that the padding holes in the structures > are set to zero. > > Fixes: 5f19c7fc6873351 ("xfs: introduce v5 inode group structure") > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > --- > v2: add comments, use memset this time Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx>