From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> Explicitly initialize the onstack structures to zero so we don't leak kernel memory into userspace when converting the in-core structure to the v1 ioctl structure. Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> --- fs/xfs/xfs_ioctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c index f193f7b288ca..44e1a290f053 100644 --- a/fs/xfs/xfs_ioctl.c +++ b/fs/xfs/xfs_ioctl.c @@ -719,7 +719,7 @@ xfs_fsbulkstat_one_fmt( struct xfs_ibulk *breq, const struct xfs_bulkstat *bstat) { - struct xfs_bstat bs1; + struct xfs_bstat bs1 = { 0 }; xfs_bulkstat_to_bstat(breq->mp, &bs1, bstat); if (copy_to_user(breq->ubuffer, &bs1, sizeof(bs1))) @@ -732,7 +732,7 @@ xfs_fsinumbers_fmt( struct xfs_ibulk *breq, const struct xfs_inumbers *igrp) { - struct xfs_inogrp ig1; + struct xfs_inogrp ig1 = { 0 }; xfs_inumbers_to_inogrp(&ig1, igrp); if (copy_to_user(breq->ubuffer, &ig1, sizeof(struct xfs_inogrp)))