On Tue, Jul 16, 2019 at 10:05:03PM -0700, Christoph Hellwig wrote: > I wonder if this should go with the rest of the buffered I/O code into > buffered-io.c? Yes, it would need an ifdef, but it is closely related > to it in how we use the page private information. Hmmm, I suppose the fact that we need a page migration function that moves page_private from one page to another reflects what we do with pages, even though we don't explicitly dereference the page private pointer itself. > > diff --git a/fs/iomap/migrate.c b/fs/iomap/migrate.c > > new file mode 100644 > > index 000000000000..d8116d35f819 > > --- /dev/null > > +++ b/fs/iomap/migrate.c > > @@ -0,0 +1,39 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (C) 2010 Red Hat, Inc. > > + * Copyright (c) 2016-2018 Christoph Hellwig. > > + */ > > Bit if you don't want to move it, this is all new code from me from > 2018. Ok, will shove it all into buffered-io.c then. --D
