On 7/16/19 6:38 AM, Carlos Maiolino wrote: >> +typedef unsigned int xfs_buf_flags_t; > I'd argue about the need of hiding an unsigned int into a typedef, which IMHO > doesn't look necessary here, but I also don't see why not if your main reason is > try to care about your sanity and bring xfsprogs code closer to kernel, other > than that, the patch is fine and you can add my review tag with or without the > typedef. > > Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx> > > Cheers > The point is to match the kernel code, warts and all. thanks, -Eric
