On Fri, Jul 12, 2019 at 12:46:17PM -0500, Eric Sandeen wrote: > Add an XFS_ICHGTIME_CREATE case to xfs_trans_ichgtime() to keep in > sync with userspace. (Currently no kernel caller sends this flag.) > > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> > --- > > diff --git a/fs/xfs/libxfs/xfs_trans_inode.c b/fs/xfs/libxfs/xfs_trans_inode.c > index 93d14e47269d..a9ad90926b87 100644 > --- a/fs/xfs/libxfs/xfs_trans_inode.c > +++ b/fs/xfs/libxfs/xfs_trans_inode.c > @@ -66,6 +66,10 @@ xfs_trans_ichgtime( > inode->i_mtime = tv; > if (flags & XFS_ICHGTIME_CHG) > inode->i_ctime = tv; > + if (flags & XFS_ICHGTIME_CREATE) { > + ip->i_d.di_crtime.t_sec = (int32_t)tv.tv_sec; > + ip->i_d.di_crtime.t_nsec = (int32_t)tv.tv_nsec; > + } Could we add a "for libxfs" or some such one liner comment to this so long as this is unused in the kernel? With that: Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx> > } > > /* > >