On 2019/7/11 5:49, Eric Sandeen wrote:
To save time, I'll merge this with my edits if you agree:
Please merge it with your edits, thanks. Best regards, Alvin
mkfs.xfs.8: Fix an inconsistency between the code and the man page. From: Alvin Zheng <Alvin@xxxxxxxxxxxxxxxxx> The man page currently states that block and sector size units cannot be used for other option values unless they are explicitly specified, when in fact the default sizes will be used in that case. Change the man page to clarify this. Signed-off-by: Alvin Zheng <Alvin@xxxxxxxxxxxxxxxxx> [sandeen: sector/block values do not need to be specified first] Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx> --- diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8 index 78b15015..9d762a43 100644 --- a/man/man8/mkfs.xfs.8 +++ b/man/man8/mkfs.xfs.8 @@ -115,9 +115,9 @@ When specifying parameters in units of sectors or filesystem blocks, the .B \-s option or the .B \-b -option first needs to be added to the command line. -Failure to specify the size of the units will result in illegal value errors -when parameters are quantified in those units. +option may be used to specify the size of the sector or block. +If the size of the block or sector is not specified, the default sizes +(block: 4KiB, sector: 512B) will be used. .PP Many feature options allow an optional argument of 0 or 1, to explicitly disable or enable the functionality. @@ -136,10 +136,6 @@ The filesystem block size is specified with a in bytes. The default value is 4096 bytes (4 KiB), the minimum is 512, and the maximum is 65536 (64 KiB). .IP -To specify any options on the command line in units of filesystem blocks, this -option must be specified first so that the filesystem block size is -applied consistently to all options. -.IP Although .B mkfs.xfs will accept any of these values and create a valid filesystem, @@ -901,10 +897,6 @@ is 512 bytes. The minimum value for sector size is .I sector_size must be a power of 2 size and cannot be made larger than the filesystem block size. -.IP -To specify any options on the command line in units of sectors, this -option must be specified first so that the sector size is -applied consistently to all options. .RE .TP .BI \-L " label"
