On Mon, Jul 08, 2019 at 10:01:03AM +1000, Dave Chinner wrote: > Ok, this doesn't look too bad from the iomap perspective, though it > does raise more questions. :) > > gfs2 now has two iopaths, right? One that uses bufferheads for > journalled data, and the other that uses iomap? That seems like it's > only a partial conversion - what needs to be done to iomap and gfs2 > to support the journalled data path so there's a single data IO > path? gfs2 always had to very different writeback I/O paths, including a copy and pasted versiom of write_cache_pages for journaled data, they just diverge a little bit more now. In the longer run I'd also like to add journaled data support to iomap for use with XFS, and then also switch gfs2 to it.