On Fri, Jun 21, 2019 at 08:18:35AM -0700, Darrick J. Wong wrote: > On Wed, May 22, 2019 at 02:05:35PM -0400, Brian Foster wrote: > > Hi all, > > > > This is v2 of the extent allocation rework series. The changes in this > > version are mostly associated with code factoring, based on feedback to > > v1. The small mode helper refactoring has been isolated and pulled to > > the start of the series. The active flag that necessitated the btree > > cursor container structure has been pushed into the xfs_btree_cur > > private area. The resulting high level allocation code in > > xfs_ag_alloc_vextent() has been cleaned up to remove an unnecessary > > level of abstraction. Finally, there are various minor cleanups and > > fixes. > > Hmmm. Just for fun I decided to apply this series to see what would > happen, and on a 1k block filesystem shook out a test failure that seems > like it could be related? > I had reproduced this earlier on and eventually determined it was kind of circumstantial with respect to this series. I had eliminated some of the operations from generic/223 for more quick reproduction/RCA and ultimately reproduced the same behavior on upstream (at the time, which was probably a month or two ago by now) with a slightly different workload. That lead to the following series: https://marc.info/?l=linux-xfs&m=155671950608062&w=2 ... which IIRC addressed the problem in both scenarios. Thoughts on those patches? Brian > MKFS_OPTIONS='-f -m reflink=1,rmapbt=1 -i sparse=1, -b size=1024, /dev/sdf' > MOUNT_OPTIONS='-o usrquota,grpquota,prjquota /dev/sdf /opt' > > --D > > --- generic/223.out > +++ generic/223.out.bad > @@ -48,7 +48,7 @@ > === Testing size 1g falloc on 8k stripe === > SCRATCH_MNT/file-1g-falloc: well-aligned > === Testing size 1073745920 falloc on 8k stripe === > -SCRATCH_MNT/file-1073745920-falloc: well-aligned > +SCRATCH_MNT/file-1073745920-falloc: Start block 197673 not multiple of sunit 2 > === mkfs with su 4 blocks x 4 === > === Testing size 1*16k on 16k stripe === > SCRATCH_MNT/file-1-16384-falloc: well-aligned > @@ -98,7 +98,7 @@ > === Testing size 1g falloc on 16k stripe === > SCRATCH_MNT/file-1g-falloc: well-aligned > === Testing size 1073745920 falloc on 16k stripe === > -SCRATCH_MNT/file-1073745920-falloc: well-aligned > +SCRATCH_MNT/file-1073745920-falloc: Start block 197673 not multiple of sunit 4 > === mkfs with su 8 blocks x 4 === > === Testing size 1*32k on 32k stripe === > SCRATCH_MNT/file-1-32768-falloc: well-aligned > @@ -148,7 +148,7 @@ > === Testing size 1g falloc on 32k stripe === > SCRATCH_MNT/file-1g-falloc: well-aligned > === Testing size 1073745920 falloc on 32k stripe === > -SCRATCH_MNT/file-1073745920-falloc: well-aligned > +SCRATCH_MNT/file-1073745920-falloc: Start block 197673 not multiple of sunit 8 > === mkfs with su 16 blocks x 4 === > === Testing size 1*64k on 64k stripe === > SCRATCH_MNT/file-1-65536-falloc: well-aligned > @@ -198,7 +198,7 @@ > === Testing size 1g falloc on 64k stripe === > SCRATCH_MNT/file-1g-falloc: well-aligned > === Testing size 1073745920 falloc on 64k stripe === > -SCRATCH_MNT/file-1073745920-falloc: well-aligned > +SCRATCH_MNT/file-1073745920-falloc: Start block 197665 not multiple of sunit 16 > === mkfs with su 32 blocks x 4 === > === Testing size 1*128k on 128k stripe === > SCRATCH_MNT/file-1-131072-falloc: well-aligned
