On Wed, Jun 26, 2019 at 02:03:32PM +0200, Andreas Gruenbacher wrote: > Marking the inode dirty for each page copied into the page cache can be > very inefficient for file systems that use the VFS dirty inode tracking, > and is completely pointless for those that don't use the VFS dirty inode > tracking. So instead, only set an iomap flag when changing the in-core > inode size, and open code the rest of __generic_write_end. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Signed-off-by: Andreas Gruenbacher <agruenba@xxxxxxxxxx> Nitpick: a patch from you should never have me as the first signoff. Just drop it, and if you feel fancy add a 'Partially based on code from Christoph Hellwig.' sentence. Not that I care much. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx> Doesn't the series also need a third patch reducing the amount of mark_inode_dirty calls as per your initial proposal?
