On 6/25/19 8:42 PM, Yang Xu wrote: > on 2019/06/12 23:01, Darrick J. Wong wrote: > >> On Wed, Jun 12, 2019 at 05:09:35PM +0800, Yang Xu wrote: >>> Since commit 2cf637cf(mkfs: remove logarithm based CLI options), >>> xfsprogs has discarded log options in node_options, remove it in usage. >>> >>> Signed-off-by: Yang Xu<xuyang2018.jy@xxxxxxxxxxxxxx> >> Looks ok, >> Reviewed-by: Darrick J. Wong<darrick.wong@xxxxxxxxxx> >> >> --D >> > Hi sandeen > > My patch missed for xfsprogs for-next branch 8bfb5eac. > By the way, the patch only removes useless log usage in inode option. > So I think we don't need to resubmit it again. Thanks for the reminder and sorry for missing it. Funny, I tried to fix this too but missed some ;) I'll get it in the next push. commit c66bd30ed7aecb429cfe3400c32892d7bc78e75b Author: Eric Sandeen <sandeen@xxxxxxxxxx> Date: Thu Jan 4 13:56:29 2018 -0600 mkfs: un-document removed logarithm based CLI options Remove logarithm-based options from usage() and manpage. Fixes: 70f72d5 "mkfs: remove logarithm based CLI options" Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx> Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>