On 6/25/19 6:02 AM, Christoph Hellwig wrote: > On Thu, Jun 20, 2019 at 08:46:26PM -0500, Eric Sandeen wrote: >> There are many, many xfs header files which are included but >> unneeded (or included twice) in the xfs code, so remove them. >> >> nb: xfs_linux.h includes about 9 headers for everyone, so those >> explicit includes get removed by this. I'm not sure what the >> preference is, but if we wanted explicit includes everywhere, >> a followup patch could remove those xfs_*.h includes from >> xfs_linux.h and move them into the files that need them. >> Or it could be left as-is. >> >> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> > > Do you have a script testing what includes are needed? I used a hacked up version of ESR's "deheader" tool (hacked up to invoke a kernel build, with -Werror turned on so warnings from dropped header files would make them look "needed") -Eric > Either way, this looks good to me: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> >
