Re: [PATCH 3/6] libxfs: fix uncached buffer refcounting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 21, 2019 at 12:57:12PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> Currently, uncached buffers in userspace are created with zero refcount
> and are fed to cache_node_put when they're released.  This is totally
> broken -- the refcount should be 1 (because the caller now holds a
> reference) and we should never be dumping uncached buffers into the
> cache.  Fix both of these problems.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux