On Mon, Jun 24, 2019 at 08:46:01AM -0700, Darrick J. Wong wrote: > This looks like a straight code copy from fs/xfs/ into fs/iomap.c. > That's fine with me, but seeing as this file is now ~2700 lines long, > perhaps we should break this up among major functional lines? > > Looking at fs/iomap.c, I see... > > * Basic iomap iterator functions (~40 lines) > * Page cache management (readpage*, write, mkwrite) (~860 lines) > * Zeroing (~80 lines) > * FIEMAP and seek hole / seek data (~300 lines) > * directio (~500 lines) > * swapfiles (~170 lines) > * and now, page cache writeback (~520 lines) > > If I have spare time this week (ha ha) I'll see if I can break all this > up (as a separate patch series), so for this: Meh. Not sure I'm a fan of too fine grained splits like the one above. And ~3k lines is still pretty manageable. But yes, once it grows むore it might be worth splitting a bit.
