On Mon, 2019-06-24 at 16:06 -0700, Darrick J. Wong wrote: > On Tue, Jun 25, 2019 at 08:35:54AM +1000, Dave Chinner wrote: > > On Mon, Jun 24, 2019 at 10:29:43AM -0700, Darrick J. Wong wrote: > > > On Mon, Jun 24, 2019 at 10:58:30AM +0800, Ian Kent wrote: > > > > The mount-api doesn't have a "human unit" parse type yet so > > > > the options that have values like "10k" etc. still need to > > > > be converted by the fs. > > > > > > /me wonders if that ought to be lifted to fs_parser.c, or is xfs the > > > only filesystem that has mount options with unit suffixes? > > > > I've suggested the same thing (I've seen this patchset before :) > > and ISTR it makes everything easier if we just keep it here for this > > patchset and then lift it once everything is merged... > > Ok, fair enough. :) I mentioned it to David after Dave said much the same thing, David said he had done some work on it but I haven't heard more yet. > > --D > > > -Dave. > > -- > > Dave Chinner > > david@xxxxxxxxxxxxx