On Wed, May 22, 2019 at 02:05:39PM -0400, Brian Foster wrote: > xfs_alloc_ag_vextent_small() doesn't update the output parameters in > the event of an AGFL allocation. Instead, it updates the > xfs_alloc_arg structure directly to complete the allocation. > > Update both args and the output params to provide consistent > behavior for future callers. > > Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx> > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Looks ok, Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> --D > --- > fs/xfs/libxfs/xfs_alloc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c > index 436f8eb0bc4c..e2fa58f4d477 100644 > --- a/fs/xfs/libxfs/xfs_alloc.c > +++ b/fs/xfs/libxfs/xfs_alloc.c > @@ -759,8 +759,8 @@ xfs_alloc_ag_vextent_small( > } > xfs_trans_binval(args->tp, bp); > } > - args->len = 1; > - args->agbno = fbno; > + *fbnop = args->agbno = fbno; > + *flenp = args->len = 1; > XFS_WANT_CORRUPTED_GOTO(args->mp, > fbno < be32_to_cpu(XFS_BUF_TO_AGF(args->agbp)->agf_length), > error); > -- > 2.17.2 >
