On Mon, Jun 17, 2019 at 09:55:44AM -0500, Eric Sandeen wrote: > On 6/15/19 11:43 AM, Darrick J. Wong wrote: > > On Fri, Jun 14, 2019 at 04:17:10PM -0500, Eric Sandeen wrote: > >> On 6/7/19 2:29 PM, Darrick J. Wong wrote: > >>> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > >>> > >>> Break out the xfs file attribute get and set ioctls into a separate > >>> manpage to reduce clutter in xfsctl. > >> > >> <comes up for air> > >> > >> Now that we've uh, hoisted it to be a generic vfs interface, > >> FS_IOC_FSGETXATTR, shouldn't we be documenting it as that instead > >> of the (old) xfs variant? > > > > No, first we document the old xfs ioctl, then we move the manpage over > > to the main man-pages.git project as the vfs ioctl, and then we update > > the xfsprogs manpage to say "Please refer to the VFS documentation but > > in case your system doesn't have it, here you go..." :) > > I guess it's kind of a sad state of affairs that I'm not quite sure > if this is serious. :) It is, because the other implementers of this ioctl are not maintaining the same behavior as xfs. The first step to doing that is to document our behaviors, and then get the code under testing. Granted, those users (ext4/f2fs) aren't using most of the fields or flags anyway so there's not a lot to test... --D > >> > >> (honestly that'd be mostly just search and replace for this patch) > >> > >> Except of course XFS_IOC_FSGETXATTRA has no vfs variant. :/ > >> > >> I also wonder if FS_IOC_SETFLAGS should be mentioned, and/or a > >> SEE_ALSO because some of the functionality overlaps? > > > > Oh, wow, there's actually a manpage for it... > > > > ...bleh, it's the weekend, I'll respond to the rest later. > > ok thanks > > -Eric
