On Thu, Jun 13, 2019 at 08:02:40PM +0200, Christoph Hellwig wrote: > Hi all, > > I've recently been trying to debug issue related to latencies related to > locked buffers and went all over our log item lifecycles for that. > > It turns out a lot of code in that area is rather obsfucated and > redundant. This series is almost entirely cleanups, but there are lots > of it. The only exception is a fix for systematic memory leaks which > appears entirely theoretical. > > Note that this series sits on top of the series titled > "use bios directly in the log code v4". To make everyones life easier > a git tree is available here: > > git://git.infradead.org/users/hch/xfs.git xfs-log-item-cleanup > > Gitweb: > > http://git.infradead.org/users/hch/xfs.git/shortlog/refs/heads/xfs-log-item-cleanup Generally looks good enough for wider testing, so for patches 1-4 and 6-20... Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> --D > > > Changes since v1: > - improve a few commit messages > - add various comments > - minor code style fixes > - drop the patch to remove iop_pushed from the quotaoff item > - set XFS_LI_ABORTED earlier in xfs_trans_committed_bulk
