On Wed, Jun 05, 2019 at 09:14:47PM +0200, Christoph Hellwig wrote: > Hi all, > > this series switches the log writing and log recovery code to use bios > directly, and remove various special cases from the buffer cache code. > > A git tree is available here: > > git://git.infradead.org/users/hch/xfs.git xfs-log-bio > > Gitweb: > > http://git.infradead.org/users/hch/xfs.git/shortlog/refs/heads/xfs-log-bio I don't know if either (a) I'll find something in the other log cleanup series to comment on or (b) if Dave has any further thoughts about whatever it is he's doing with xfs_buf in userspace. However, for patches 1-15 and 17-24, I think this looks good enough for more widespread testing, so... Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> --D > > Chances since v3: > - add a few additional cleanup patches > - clean up iclog allocation > - drop a not required vmap invalidation > - better document the iclog size fields > - fix vmap invalidation > > Changes since v2: > - rename the 'flush' flag to 'need_flush' > - spelling fixes > - minor cleanups > > Changes since v1: > - rebased to not required the log item series first > - split the bio-related code out of xfs_log_recover.c into a new file > to ease using xfs_log_recover.c in xfsprogs > - use kmem_alloc_large instead of vmalloc to allocate the buffer > - additional minor cleanups