Re: [PATCH 05/24] xfs: remove the l_iclog_size_log field from strut xlog

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 05, 2019 at 09:14:52PM +0200, Christoph Hellwig wrote:
> This field is never used, so we can simply kill it.

s/strut xlog/struct xlog/ in the subject; will fix it in the series if I
end up pulling it in...

Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

--D


> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
>  fs/xfs/xfs_log.c      | 9 ---------
>  fs/xfs/xfs_log_priv.h | 1 -
>  2 files changed, 10 deletions(-)
> 
> diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
> index a2048e46be4e..8033b64092bb 100644
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -1307,7 +1307,6 @@ xlog_get_iclog_buffer_size(
>  	struct xfs_mount	*mp,
>  	struct xlog		*log)
>  {
> -	int size;
>  	int xhdrs;
>  
>  	if (mp->m_logbufs <= 0)
> @@ -1319,13 +1318,6 @@ xlog_get_iclog_buffer_size(
>  	 * Buffer size passed in from mount system call.
>  	 */
>  	if (mp->m_logbsize > 0) {
> -		size = log->l_iclog_size = mp->m_logbsize;
> -		log->l_iclog_size_log = 0;
> -		while (size != 1) {
> -			log->l_iclog_size_log++;
> -			size >>= 1;
> -		}
> -
>  		if (xfs_sb_version_haslogv2(&mp->m_sb)) {
>  			/* # headers = size / 32k
>  			 * one header holds cycles from 32k of data
> @@ -1346,7 +1338,6 @@ xlog_get_iclog_buffer_size(
>  
>  	/* All machines use 32kB buffers by default. */
>  	log->l_iclog_size = XLOG_BIG_RECORD_BSIZE;
> -	log->l_iclog_size_log = XLOG_BIG_RECORD_BSHIFT;
>  
>  	/* the default log size is 16k or 32k which is one header sector */
>  	log->l_iclog_hsize = BBSIZE;
> diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
> index b5f82cb36202..78a2abeba895 100644
> --- a/fs/xfs/xfs_log_priv.h
> +++ b/fs/xfs/xfs_log_priv.h
> @@ -361,7 +361,6 @@ struct xlog {
>  	int			l_iclog_heads;  /* # of iclog header sectors */
>  	uint			l_sectBBsize;   /* sector size in BBs (2^n) */
>  	int			l_iclog_size;	/* size of log in bytes */
> -	int			l_iclog_size_log; /* log power size of log */
>  	int			l_iclog_bufs;	/* number of iclog buffers */
>  	xfs_daddr_t		l_logBBstart;   /* start block of log */
>  	int			l_logsize;      /* size of log in bytes */
> -- 
> 2.20.1
> 



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux