On 6/13/19 11:45 PM, Christoph Hellwig wrote: > On Fri, Jun 14, 2019 at 09:19:47AM +0800, Ming Lei wrote: >> On Thu, Jun 13, 2019 at 04:04:03AM -0600, Jens Axboe wrote: >>> On 6/13/19 3:55 AM, Christoph Hellwig wrote: >>>> Hi Jens, hi Ming, >>>> >>>> this is the tested and split version of what I think is the better >>>> fix for the get_user_pages page leak, as it leaves the intelligence >>>> in the callers instead of in bio_try_to_merge_page. >>>> >>>> Changes since v1: >>>> - drop patches not required for 5.2 >>>> - added Reviewed-by tags >>> >>> Applied for 5.2, thanks. >> >> Hi Jens & Christoph, >> >> Looks the following change is missed in patch 1, otherwise kernel oops >> is triggered during kernel booting: > > Ok, true, sorry. > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> I've dropped the two patches. Please send them again, when they are tested. Not making -rc5 at this time. -- Jens Axboe