On 6/12/19 4:11 AM, Ming Lei wrote: > On Wed, Jun 12, 2019 at 09:45:27AM +0200, Christoph Hellwig wrote: >> On Wed, Jun 12, 2019 at 09:09:23AM +0800, Ming Lei wrote: >>> We have to backport the fixes to -stable tree, and downstream need to >>> ship the fix too. >>> >>> The issue is quite serious because the leak is in IO path and the whole >>> system ram can be used up easily on some workloads. So I think the fix >>> should be for 5.2, however, regression risk might be increased by >>> pulling cleanup & re-factor in now. >>> >>> I really appreciate you may cook a fix-only patch for this issue. >>> Especially the change in add pc page code isn't necessary for fixing >>> the issue. >> >> Patches 3 and 4 have no dependencies on 1 and 2, and should have >> arguably been ordered first in the series. > > OK, that is good to make patch 3 &4 into 5.2, I will give a review > soon. I'll echo Mings sentiments here, for the series. -- Jens Axboe
