On Tue, Jun 11, 2019 at 6:59 PM Theodore Ts'o <tytso@xxxxxxx> wrote: > > On Tue, Jun 11, 2019 at 06:39:16PM +0300, Amir Goldstein wrote: > > Depending on filesystem, copying from active swapfile may be allowed, > > just as read from swapfile may be allowed. > > > > Note the kernel fix commit in test description. > > > > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> > > > > Per your and Ted's request, I've documented the kernel fix commit > > in the new copy_range tests. Those commits are now on Darrick's > > copy-file-range-fixes branch, which is on its way to linux-next > > and to kernel 5.3. > > Thanks! Are we sure at this point that the commit won't need to be > modified / rebased in Darrick's tree? > Yes. The intention is that fs maintainers can now rebase their v5.3 development branch on this non-rewindable branch. Note that you do still need to merge the fixes from Darrick's branch for ext4 to pass this test despite relaxing the "copy from swapfile" test case. Thanks, Amir.