Re: [PATCH 06/24] xfs: cleanup xlog_get_iclog_buffer_size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 05, 2019 at 09:14:53PM +0200, Christoph Hellwig wrote:
> We don't really need all the messy branches in the function, as it
> really does three things, out of which 2 are common for all branches:
> 
>  1) set up mount point log buffer size and count values if not already
>     done from mount options
>  2) calculate the number of log headers
>  3) set up all the values in struct xlog based on the above
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Nice cleanup!

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux