On Wed, Jun 05, 2019 at 08:05:18AM +1000, Dave Chinner wrote: > On Tue, Jun 04, 2019 at 02:49:19PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > inode_cluster_size is supposed to represent the size (in bytes) of an > > inode cluster buffer. We avoid having to handle multiple clusters per > > filesystem block on filesystems with large blocks by openly rounding > > this value up to 1 FSB when necessary. However, we never reset > > inode_cluster_size to reflect this new rounded value, which adds to the > > potential for mistakes in calculating geometries. > > > > Fix this by setting inode_cluster_size to reflect the rounded-up size if > > needed, and special-case the few places in the sparse inodes code where > > we actually need the smaller value to validate on-disk metadata. > > > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > LGTM. > > Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> Thanks for the review! --D > > -- > Dave Chinner > david@xxxxxxxxxxxxx
