On 5/21/19 2:19 PM, Christoph Hellwig wrote: > On Tue, May 21, 2019 at 01:59:58PM -0500, Eric Sandeen wrote: >> So yeah I'm of the opinion that unless it's kernel(-ish?) code it should be >> positive, and I can send a patch to clean up stuff that's not. >> >> I can be swayed by counterarguments if you have them. :) > > What speaks against everything is negative? It isn't like returning > positive errors really is a traditional userspace convention, as that > is return -1 (negative!) and look at errno.. Sorry, I wasn't clear - I meant returning negative errnos. That's the part that's not consistent. -Eric
