Re: [PATCH] xfsdump: add a space after commas and semicolons where was none

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/17/19 6:52 AM, Jan Tulak wrote:
> @@ -3130,7 +3130,7 @@ static tsi_cmd_tbl_t tsi_cmd_tbl[] = {
>  	{ "cd",		"[ <path> ]",			tsi_cmd_cd,	1, 2 },
>  	{ "add",	"[ <path> ]",			tsi_cmd_add,	1, 2 },
>  	{ "delete",	"[ <path> ]",			tsi_cmd_delete,	1, 2 },
> -	{ "extract",	"",				tsi_cmd_extract,1, 1 },
> +	{ "extract",	"",				tsi_cmd_extract, 1, 1 },
>  	{ "quit",	"",				tsi_cmd_quit,	1, 1 },
>  	{ "help",	"",				tsi_cmd_help,	1, 1 },
>  };

I dropped a couple of hunks like this one, where bending the rules can
actually help readability by keeping things aligned.

Otherwise, looks fine, thanks.

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux