Re: [PATCH] xfs_db: add extent count and file size histograms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/15/19 10:57 AM, Jorge Guerra wrote:
> Thanks Eric,
> 
> I'm addressing these comments.  Will send an update once we have an
> agreement with Dave into how and where to implement this.

Might want to give Dave's concerns thought before doing too much
editing of this patch, but it's up to you.  :)

(same style comments will apply to any solution, though)

Thanks,
-Eric

> On Tue, May 14, 2019 at 1:02 PM Eric Sandeen <sandeen@xxxxxxxxxxx> wrote:
>>
>> On 5/14/19 1:50 PM, Jorge Guerra wrote:
>>> +             dbprintf(_("capacity used (bytes): %llu (%.3f %cB)\n"),
>>> +             extstats.logicalused, answer, iec_prefixes[i]);
>>
>> I think I missed this instance of "indent please" and probably others...
>>
>> (I'm kind of wondering about carrying 'used' in bytes, but I suppose we're
>> ok until we really get zettabyte filesytems in the wild) ;)
>>
>> -Eric
> 
> 
> 



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux