> +out: > + if (error) > + trace_xfs_alloc_agfl_error(args); > + else > + trace_xfs_alloc_agfl_done(args); > return error; Splitting this into an out and an out_error label might be a little nicer. Otherwise this looks fine: Reviewed-by: Christoph Hellwig <hch@xxxxxx>