On Tue, May 14, 2019 at 07:17:44PM -0500, Eric Sandeen wrote: > Remove many unused #defines and functions. > > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> > --- .... > /* miscellaneous kernel routines not in user space */ > -#define down_read(a) ((void) 0) > -#define up_read(a) ((void) 0) > #define spin_lock_init(a) ((void) 0) > #define spin_lock(a) ((void) 0) > #define spin_unlock(a) ((void) 0) The lack of locking in the userspace code scares me somewhat :P > @@ -400,7 +397,6 @@ roundup_64(uint64_t x, uint32_t y) > > #define XBRW_READ LIBXFS_BREAD > #define XBRW_WRITE LIBXFS_BWRITE > -#define xfs_buf_iomove(bp,off,len,data,f) libxfs_iomove(bp,off,len,data,f) > #define xfs_buf_zero(bp,off,len) libxfs_iomove(bp,off,len,NULL,LIBXFS_BZERO) > > /* mount stuff */ > @@ -436,8 +432,6 @@ roundup_64(uint64_t x, uint32_t y) > #define xfs_sort qsort > > #define xfs_ilock(ip,mode) ((void) 0) > -#define xfs_ilock_nowait(ip,mode) ((void) 0) > -#define xfs_ilock_demote(ip,mode) ((void) 0) Especially that we have transactions that run without inode locks. But that's not a problem this patch solves, so may as well get rid of the unused interfaces... Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx
