If there are no attributes on the inode, don't go through the cost of memory allocation and callling xfs_attr_get when we already know we'll just get -ENOATTR. Reported-by: David Valin <dvalin@xxxxxxxxxx> Suggested-by: Dave Chinner <david@xxxxxxxxxxxxx> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> --- diff --git a/fs/xfs/xfs_acl.c b/fs/xfs/xfs_acl.c index 8039e35147dd..b469b44e9e71 100644 --- a/fs/xfs/xfs_acl.c +++ b/fs/xfs/xfs_acl.c @@ -132,6 +132,9 @@ xfs_get_acl(struct inode *inode, int type) BUG(); } + if (!xfs_inode_hasattr(ip)) + return NULL; + /* * If we have a cached ACLs value just return it, not need to * go out to the disk.
