On Mon, May 6, 2019 at 8:19 PM Eric Sandeen <sandeen@xxxxxxxxxxx> wrote:
>
> On 5/6/19 8:14 AM, Brian Foster wrote:
> > On Mon, May 06, 2019 at 01:52:12PM +0200, Jan Tulak wrote:
> >> diff --git a/common/drive.c b/common/drive.c
> >> index b01b916..a3514a9 100644
> >> --- a/common/drive.c
> >> +++ b/common/drive.c
> > ...
> >> @@ -3088,7 +3088,7 @@ prepare_drive(drive_t *drivep)
> >> * if not present or write-protected during dump, return.
> >> */
> >> maxtries = 15;
> >> - for (try = 1 ; ; sleep(10), try++) {
> >> + for (try = 1;; sleep(10), try++) {
> >
> > FWIW, I think the spaces actually make sense in contexts like the above
> > where we've intentionally left a statement empty. Without the space this
> > kind of looks like a double semicolon, which is slightly misleading at a
> > glance.
>
> Haha, yikes, how DOES one make this prettier w/o just killing it
> with fire? ;)
>
> -Eric
TBH, I thought about rewriting it. But then I realised how deep that
rabbit hole leads... So I'm sticking with formatting changes for now.
Jan
--
Jan Tulak
