Re: [PATCH 3/4] xfs_restore: fix unsupported ioctl detection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Looks ok to me
Reviewed-by: Allison Collins <allison.henderson@xxxxxxxxxx>

On 2/22/19 9:47 AM, Darrick J. Wong wrote:
From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

Linux ioctls can return ENOTTY or EOPNOTSUPP, so filter both of them
when logging reservation failure.

Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
---
  restore/dirattr.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/restore/dirattr.c b/restore/dirattr.c
index 4257a1b..3fa8fb6 100644
--- a/restore/dirattr.c
+++ b/restore/dirattr.c
@@ -76,7 +76,7 @@ create_filled_file(
  		return fd;
ret = ioctl(fd, XFS_IOC_RESVSP64, &fl);
-	if (ret && errno != ENOTTY)
+	if (ret && (errno != EOPNOTSUPP && errno != ENOTTY))
  		mlog(MLOG_VERBOSE | MLOG_NOTE,
  _("attempt to reserve %lld bytes for %s using %s failed: %s (%d)\n"),
  				size, pathname, "XFS_IOC_RESVSP64",




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux