Re: [PATCH] db/malloc: Use posix_memalign instead of deprecated valloc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 5/6/19 4:03 PM, Rosen Penev wrote:
> valloc is not available with uClibc-ng as well as being deprecated, which
> causes compilation errors. aligned_alloc is not available before C11 so
> used posix_memalign.'
> 
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> ---
>  db/malloc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/db/malloc.c b/db/malloc.c
> index 77b3e022..38fe0b05 100644
> --- a/db/malloc.c
> +++ b/db/malloc.c
> @@ -44,8 +44,7 @@ xmalloc(
>  {
>  	void	*ptr;
>  
> -	ptr = valloc(size);
> -	if (ptr)
> +	if(!posix_memalign(&ptr, sysconf(_SC_PAGESIZE), size))


I'll stick a space after the 'if' but otherwise, seems fine, thanks.

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>


>  		return ptr;
>  	badmalloc();
>  	/* NOTREACHED */
> 



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux