On 5/2/19 7:57 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
>
> Enable reflink and reverse mapping by default.
Soooo until now, I thought I had understood that rmap was unlikely
to be default ever, due to performance impacts. Is this no longer the case?
Of course I can't find any emails or IRC logs to indicate I didn't
just dream this up...
Also, at this point, remind me again what uses rmap and why it should
be enabled now?
-Eric
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> ---
> mkfs/xfs_mkfs.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index 0862621a..3874f7dd 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -2021,14 +2021,14 @@ _("sparse inodes not supported without CRC support\n"));
> }
> cli->sb_feat.spinodes = false;
>
> - if (cli->sb_feat.rmapbt) {
> + if (cli->sb_feat.rmapbt && cli_opt_set(&mopts, M_RMAPBT)) {
> fprintf(stderr,
> _("rmapbt not supported without CRC support\n"));
> usage();
> }
> cli->sb_feat.rmapbt = false;
>
> - if (cli->sb_feat.reflink) {
> + if (cli->sb_feat.reflink && cli_opt_set(&mopts, M_REFLINK)) {
> fprintf(stderr,
> _("reflink not supported without CRC support\n"));
> usage();
> @@ -3934,8 +3934,8 @@ main(
> .dirftype = true,
> .finobt = true,
> .spinodes = true,
> - .rmapbt = false,
> - .reflink = false,
> + .rmapbt = true,
> + .reflink = true,
> .parent_pointers = false,
> .nodalign = false,
> .nortalign = false,
>
