On Tue, Apr 23, 2019 at 09:20:25AM +1000, Dave Chinner wrote: > On Mon, Apr 22, 2019 at 11:25:41AM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > We passed an inode into xfs_ioctl_setattr_get_trans with join_flags > > indicating which locks are held on that inode. If we can't allocate a > > transaction then we need to unlock the inode before we bail out, like > > all the other error paths do. > > > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Yup, that's a problem, and the function header comment says "we now > take full responsibility for unlocking the inode" so this looks > fine. Cool. Thanks for the review! --D > Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> > > -- > Dave Chinner > david@xxxxxxxxxxxxx
