On Mon, Apr 15, 2019 at 05:19:49PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
>
> Now that we no longer memset the scrub context, we can move the
> already_fixed variable into the scrub context's state flags instead of
> passing around pointers to separate stack variables.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
Minor comment below, otherwise
Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
> diff --git a/fs/xfs/scrub/scrub.h b/fs/xfs/scrub/scrub.h
> index 60359e7de930..1b23bf141438 100644
> --- a/fs/xfs/scrub/scrub.h
> +++ b/fs/xfs/scrub/scrub.h
> @@ -63,16 +63,17 @@ struct xfs_scrub {
> void *buf;
> uint ilock_flags;
>
> - /* See the XCHK state flags below. */
> + /* See the XCHK/XREP state flags below. */
> unsigned int flags;
>
> /* State tracking for single-AG operations. */
> struct xchk_ag sa;
> };
>
> -/* XCHK state flags */
> +/* XCHK/XREP state flags */
> #define XCHK_TRY_HARDER (1 << 0) /* can't get resources, try again */
> #define XCHK_HAS_QUOTAOFFLOCK (1 << 1) /* we hold the quotaoff lock */
> +#define XREP_ALREADY_FIXED (1 << 31) /* checking our repair work */
>
Can you just put a comment here saying xchk flags grow from the
bottom up, XREP grow from the top down?
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
