Re: [PATCH] nvme/012 & 013: avoid extremely slow xfs IO

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks for the patch Ming. Couple of comments below.
On 4/14/19 6:22 PM, Ming Lei wrote:
> It is observed that nvme/012 may take ~17 minutes to complete on aarch64,
> even worse it may trigger IO timeout on nvme-loop.
> 
> Eric and Dave replied that it is because of too small log size on small
> disk.
> 
> So pass '-l size=32m' to avoid the issue.
> 
> With this patch, nvme/012 can be completed in one minute.
> 
Then we should set the QUICK=1 if its taking shorter time.

> Cc: Eric Sandeen <esandeen@xxxxxxxxxx>
> Cc: Dave Chinner <dchinner@xxxxxxxxxx>
> Cc: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
> Cc: linux-xfs@xxxxxxxxxxxxxxx
> Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxx>
> ---
>   tests/nvme/012 | 2 +-
>   tests/nvme/013 | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/nvme/012 b/tests/nvme/012
> index 9a6801511df7..d7a8751ec752 100755
> --- a/tests/nvme/012
> +++ b/tests/nvme/012
> @@ -46,7 +46,7 @@ test() {
>   
>   	umount ${mount_dir} > /dev/null 2>&1
>   
> -	mkfs.xfs -f /dev/"${nvmedev}n1" > /dev/null 2>&1
> +	mkfs.xfs -l size=32m -f /dev/"${nvmedev}n1" > /dev/null 2>&1
>   
As a part of this series lets move this to the helper mkfs in the 
nvme/rc and use that call in all the file-backed ns related testcases.
Let me know if you want me to do that or you would like to do that as a 
part of this series. I'm okay with anything.
>   	mount /dev/"${nvmedev}n1" "${mount_dir}"
>   
> diff --git a/tests/nvme/013 b/tests/nvme/013
> index e346cd4baa35..bc435f752dca 100755
> --- a/tests/nvme/013
> +++ b/tests/nvme/013
> @@ -44,7 +44,7 @@ test() {
>   
>   	umount ${mount_dir} > /dev/null 2>&1
>   
> -	mkfs.xfs -f /dev/"${nvmedev}n1" > /dev/null 2>&1
> +	mkfs.xfs -l size=32m  -f /dev/"${nvmedev}n1" > /dev/null 2>&1
>   
Extra space here but can be ignored once we move mkfs to the helper call.
>   	mount /dev/"${nvmedev}n1" "${mount_dir}"
>   
> 





[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux