On 3/29/19 8:46 AM, Martin K. Petersen wrote: > > Jens, > >> I didn't miss that, but it fixes nothing. That will unify the 40 bytes >> with 8 bytes, we're still growing the bio by a LOT. And we can't even >> nicely hide this behind some ifdef, sine distros enable everything and >> hence we're solving nothing by doing that. > > We'll just need to handle it exactly like the integrity stuff. We only > allocate the extra bits when the underlying device indicates that it's > required and desired. The integrity stuff still has that nasty pointer in there. It'd be nice to get rid of that as well, and hide it all in a parent container of the bio. -- Jens Axboe