On Thu, Mar 14, 2019 at 06:01:13PM -0700, Darrick J. Wong wrote:
> On Fri, Mar 15, 2019 at 11:18:32AM +1100, Nathan Scott wrote:
> > On Fri, Mar 15, 2019 at 8:04 AM Darrick J. Wong <darrick.wong@xxxxxxxxxx> wrote:
> > >
> > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> > >
> > > Use parallel make to speed up dpkg builds.
> >
> > Seems a little more involved than I woulda expected, but LGTM.
> >
> > Reviewed-by: Nathan Scott <nathans@xxxxxxxxxx>
> >
> > > for dir in include libxfs; do \
> > > - $(MAKE) -C $$dir NODEP=1 install-headers; \
> > > + $(MAKE) $(PMAKEFLAGS) -C $$dir NODEP=1 install-headers; \
> > > done; \
> >
> > OOC, does the $(MAKE) -C above warrant the same treatment as the earlier patch?
> > (i.e. removing the -C there for less verbosity)
>
> Hmm, that seems like it could be the case. I'll have a look tomorrow.
It doesn't work, because buildrules sets up $(SUBDIRS) as (phony)
targets so that you can do:
$ make scrub
and have the top level Makefile set Q and then recurse into scrub/
instead of doing it yourself ("make -C scrub"). That's why the previous
-C removal patch works.
The hunk of Makefile you're talking about does:
$ make -C include install-headers
which is different because install-headers is a target that only exists
in {include,libxfs}/Makefile, not the top level build system. So we
have to get make to chdir into include/ for the target to work at all.
--D
> --D
>
> > cheers.
> >
> > --
> > Nathan
