On Fri, Feb 22, 11:28, Darrick J. Wong wrote
> > > +_("attempt to reserve %lld bytes for %s using %s failed: %s (%d)\n"),
> > > + size, pathname, "XFS_IOC_RESVSP64",
> > > + strerror(errno), errno);
> >
> > The "XFS_IOC_RESVSP64" string literal can be included in the format string.
>
> I was trying not to force an update of the i18n message catalogs.
Point.
> > > + if (ret == 0)
> > > + goto done;
> > > +
> > > +done:
> >
> > LOL
>
> Yes, it's silly, but gcc will complain if the label doesn't get
> used, which it won't if you apply the rest of the series and build
> xfsdump on a system that (somehow) doesn't know about fallocate.
True. It does trigger a WTF event in wetware though, at least if you
read the patch without context of 4/4.
Anyway, thanks for the explanations
Andre
--
Max Planck Institute for Developmental Biology
Max-Planck-Ring 5, 72076 Tübingen, Germany. Phone: (+49) 7071 601 829
http://people.tuebingen.mpg.de/maan/
Attachment:
signature.asc
Description: PGP signature
