On Mon, Feb 11, 2019 at 06:17:54PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
>
> Create a test (+ helper program) that opens as many unlinked files as it
> possibly can on the scratch filesystem, then closes all the files at
> once to stress-test unlinked file cleanup. Add an xfs-specific test to
> make sure that the fallback code doesn't bitrot.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> ---
> src/Makefile | 2 -
> src/tmpfile.c | 127 +++++++++++++++++++++++++++++++++++++++++++++++++
> tests/generic/710 | 65 +++++++++++++++++++++++++
> tests/generic/710.out | 2 +
> tests/generic/711 | 73 ++++++++++++++++++++++++++++
> tests/generic/711.out | 2 +
> tests/generic/group | 2 +
> tests/xfs/736 | 71 +++++++++++++++++++++++++++
> tests/xfs/736.out | 2 +
> tests/xfs/737 | 79 ++++++++++++++++++++++++++++++
> tests/xfs/737.out | 2 +
> tests/xfs/group | 2 +
> 12 files changed, 428 insertions(+), 1 deletion(-)
> create mode 100644 src/tmpfile.c
> create mode 100755 tests/generic/710
> create mode 100644 tests/generic/710.out
> create mode 100755 tests/generic/711
> create mode 100644 tests/generic/711.out
> create mode 100755 tests/xfs/736
> create mode 100644 tests/xfs/736.out
> create mode 100755 tests/xfs/737
> create mode 100644 tests/xfs/737.out
>
>
> diff --git a/src/Makefile b/src/Makefile
> index 41826585..5fce881d 100644
> --- a/src/Makefile
> +++ b/src/Makefile
> @@ -27,7 +27,7 @@ LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \
> renameat2 t_getcwd e4compact test-nextquota punch-alternating \
> attr-list-by-handle-cursor-test listxattr dio-interleaved t_dir_type \
> dio-invalidate-cache stat_test t_encrypted_d_revalidate \
> - attr_replace_test swapon mkswap
> + attr_replace_test swapon mkswap tmpfile
>
> SUBDIRS = log-writes perf
>
> diff --git a/src/tmpfile.c b/src/tmpfile.c
> new file mode 100644
> index 00000000..1b74dc72
> --- /dev/null
> +++ b/src/tmpfile.c
> @@ -0,0 +1,127 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2019 Oracle. All Rights Reserved.
> + * Author: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> + *
> + * Test program to open unlinked files and leak them.
> + */
> +#ifndef _GNU_SOURCE
> +# define _GNU_SOURCE
> +#endif
> +#include <time.h>
> +#include <unistd.h>
> +#include <stdlib.h>
> +#include <stdio.h>
> +#include <sys/types.h>
> +#include <sys/stat.h>
> +#include <fcntl.h>
> +#include <errno.h>
> +
> +static int min_fd = -1;
> +static int max_fd = -1;
> +static unsigned int nr_opened = 0;
> +static float start_time;
> +
> +void clock_time(float *time)
> +{
> + static clockid_t clkid = CLOCK_MONOTONIC;
> + struct timespec ts;
> + int ret;
> +
> +retry:
> + ret = clock_gettime(clkid, &ts);
> + if (ret) {
> + if (clkid == CLOCK_MONOTONIC) {
> + clkid = CLOCK_REALTIME;
> + goto retry;
> + }
> + perror("clock_gettime");
> + exit(2);
> + }
> + *time = ts.tv_sec + ((float)ts.tv_nsec / 1000000000);
> +}
> +
> +/*
> + * Exit the program due to an error.
> + *
> + * If we've exhausted all the file descriptors, make sure we close all the
> + * open fds in the order we received them in order to exploit a quirk of ext4
> + * and xfs where the oldest unlinked inodes are at the /end/ of the unlinked
> + * lists, which will make removing the unlinked files maximally painful.
> + *
> + * If it's some other error, just die and let the kernel sort it out.
> + */
> +void die(void)
> +{
> + float end_time;
> + int fd;
> +
> + switch (errno) {
> + case EMFILE:
> + case ENFILE:
> + case ENOSPC:
> + clock_time(&end_time);
> + printf("Opened %u files in %.2fs.\n", nr_opened,
> + end_time - start_time);
> + fflush(stdout);
> +
> + clock_time(&start_time);
> + for (fd = min_fd; fd <= max_fd; fd++)
> + close(fd);
> + clock_time(&end_time);
> + printf("Closed %u files in %.2fs.\n", nr_opened,
> + end_time - start_time);
> + exit(0);
> + break;
> + default:
> + perror("open?");
> + exit(2);
> + break;
> + }
> +}
> +
> +/* Remember how many file we open and all that. */
> +void remember_fd(int fd)
> +{
> + if (min_fd == -1 || min_fd > fd)
> + min_fd = fd;
> + if (max_fd == -1 || max_fd < fd)
> + max_fd = fd;
> + nr_opened++;
> +}
> +
> +/* Put an opened file on the unlinked list and leak the fd. */
> +void leak_tmpfile(void)
> +{
> + int fd = -1;
> + int ret;
> +
> + /* Try to create an O_TMPFILE and leak the fd. */
> +#ifdef O_TMPFILE
> + fd = open(".", O_TMPFILE | O_RDWR, 0644);
> + if (fd >= 0) {
> + remember_fd(fd);
> + return;
> + }
> + if (fd < 0 && errno != EOPNOTSUPP)
> + die();
> +#endif
Could we track lack of tmpfile support so we don't repeat the open()
call once we know it's going to fail?
> +
> + /* Oh well, create a new file, unlink it, and leak the fd. */
> + fd = open("./moo", O_CREAT | O_RDWR, 0644);
> + if (fd < 0)
> + die();
> + ret = unlink("./moo");
> + if (ret)
> + die();
> + remember_fd(fd);
> +}
> +
> +/* Try to put as many files on the unlinked list and then kill them. */
> +int main(int argc, char *argv[])
> +{
> + clock_time(&start_time);
> + while (1)
> + leak_tmpfile();
> + return 0;
> +}
> diff --git a/tests/generic/710 b/tests/generic/710
> new file mode 100755
> index 00000000..18aa9d34
> --- /dev/null
> +++ b/tests/generic/710
> @@ -0,0 +1,65 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0+
> +# Copyright (c) 2019 Oracle, Inc. All Rights Reserved.
> +#
> +# FS QA Test No. 710
> +#
> +# Stress test creating a lot of unlinked O_TMPFILE files and closing them
> +# all at once, checking that we don't blow up the filesystem. This is sort
> +# of a performance test for the xfs unlinked inode backref patchset, but it
> +# applies to most other filesystems.
> +#
> +# Use only a single CPU to test the single threaded situation.
> +#
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +tmp=/tmp/$$
> +status=1 # failure is the default!
> +testfile=$TEST_DIR/$seq.txt
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> + cd /
> + rm -f $tmp.*
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/attr
> +. ./common/filter
Do we need attr/filter?
> +
> +# real QA test starts here
> +_supported_fs generic
> +_supported_os Linux
> +_require_scratch
> +
> +rm -f $seqres.full
> +_scratch_mkfs >> $seqres.full 2>&1
> +_scratch_mount
> +
> +# Set ULIMIT_NOFILE to min(file-max, 50000 files per LOAD_FACTOR)
> +# so that this test doesn't take forever or OOM the box
> +max_files=$((50000 * LOAD_FACTOR))
> +max_allowable_files=$(cat /proc/sys/fs/file-max)
> +test $max_files -gt $max_allowable_files && max_files=$max_allowable_files
I see the following from the above line when I run this test:
+./tests/generic/710: line 46: test: 18446744073709551615: integer expression expected
> +ulimit -n $max_files
> +
> +# Open a lot of unlinked files
> +echo create >> $seqres.full
> +program=$PWD/src/tmpfile
> +(cd $SCRATCH_MNT ; $program >> $seqres.full)
> +
> +# Unmount to prove that we can clean it all
> +echo umount >> $seqres.full
> +before=$(date +%s)
> +_scratch_unmount
> +after=$(date +%s)
> +echo "Unmount took $((after - before))s." >> $seqres.full
> +
> +# Mount so that we can run the usual checks
> +echo silence is golden
> +_scratch_mount
> +status=0
> +exit
> diff --git a/tests/generic/710.out b/tests/generic/710.out
> new file mode 100644
> index 00000000..e0a55170
> --- /dev/null
> +++ b/tests/generic/710.out
> @@ -0,0 +1,2 @@
> +QA output created by 710
> +silence is golden
> diff --git a/tests/generic/711 b/tests/generic/711
> new file mode 100755
> index 00000000..11d76218
> --- /dev/null
> +++ b/tests/generic/711
> @@ -0,0 +1,73 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0+
> +# Copyright (c) 2019 Oracle, Inc. All Rights Reserved.
> +#
> +# FS QA Test No. 711
> +#
> +# Stress test creating a lot of unlinked O_TMPFILE files and closing them
> +# all at once, checking that we don't blow up the filesystem. This is sort
> +# of a performance test for the xfs unlinked inode backref patchset, but it
> +# applies to most other filesystems.
> +#
> +# Use every CPU possible to stress the filesystem.
> +#
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +tmp=/tmp/$$
> +status=1 # failure is the default!
> +testfile=$TEST_DIR/$seq.txt
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> + cd /
> + rm -f $tmp.*
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/attr
> +. ./common/filter
> +
> +# real QA test starts here
> +_supported_fs generic
> +_supported_os Linux
> +_require_scratch
> +
> +rm -f $seqres.full
> +_scratch_mkfs >> $seqres.full 2>&1
> +_scratch_mount
> +
> +# Try to load up all the CPUs, two threads per CPU.
> +nr_cpus=$(( $(getconf _NPROCESSORS_ONLN) * 2 ))
> +
> +# Set ULIMIT_NOFILE to min(file-max, 50000 files per LOAD_FACTOR)
> +# so that this test doesn't take forever or OOM the box
> +max_files=$((50000 * LOAD_FACTOR))
> +max_allowable_files=$(( $(cat /proc/sys/fs/file-max) / nr_cpus ))
> +test $max_files -gt $max_allowable_files && max_files=$max_allowable_files
> +ulimit -n $max_files
> +
> +# Open a lot of unlinked files
> +echo create >> $seqres.full
> +program=$PWD/src/tmpfile
> +for i in $(seq 1 $nr_cpus); do
> + (mkdir $SCRATCH_MNT/$i ; cd $SCRATCH_MNT/$i ; $program >> $seqres.full) &
> +done
Doesn't this make the first test kind of a subset of this one (where
nr_cpus == 1)? If so, could we just do a couple iterations with
different nr_cpus values?
I'm wondering if we should have a log recovery test as well, btw.
> +for i in $(seq 1 $nr_cpus); do
> + wait
> +done
Can't we just pass the pids forked by the loop above? Though the manpage
says wait should wait for all child pids as it is, so perhaps the loop
is unnecessary?
Brian
> +
> +# Unmount to prove that we can clean it all
> +echo umount >> $seqres.full
> +before=$(date +%s)
> +_scratch_unmount
> +after=$(date +%s)
> +echo "Unmount took $((after - before))s." >> $seqres.full
> +
> +# Mount so that we can run the usual checks
> +echo silence is golden
> +_scratch_mount
> +status=0
> +exit
> diff --git a/tests/generic/711.out b/tests/generic/711.out
> new file mode 100644
> index 00000000..cbbe36e9
> --- /dev/null
> +++ b/tests/generic/711.out
> @@ -0,0 +1,2 @@
> +QA output created by 711
> +silence is golden
> diff --git a/tests/generic/group b/tests/generic/group
> index f56eb475..26999ca1 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -529,3 +529,5 @@
> 524 auto quick
> 525 auto quick rw
> 709 auto quick
> +710 auto quick unlink
> +711 auto quick unlink
> diff --git a/tests/xfs/736 b/tests/xfs/736
> new file mode 100755
> index 00000000..e33de0ae
> --- /dev/null
> +++ b/tests/xfs/736
> @@ -0,0 +1,71 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0+
> +# Copyright (c) 2019 Oracle, Inc. All Rights Reserved.
> +#
> +# FS QA Test No. 736
> +#
> +# Stress test creating a lot of unlinked O_TMPFILE files and closing them
> +# all at once, checking that we don't blow up the filesystem. This is sort
> +# of a performance test for the xfs unlinked inode backref patchset, but it
> +# applies to most other filesystems.
> +#
> +# Here we force the use of the slow iunlink bucket walk code in a single
> +# threaded situation.
> +#
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +tmp=/tmp/$$
> +status=1 # failure is the default!
> +testfile=$TEST_DIR/$seq.txt
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> + cd /
> + rm -f $tmp.*
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/attr
> +. ./common/filter
> +. ./common/inject
> +
> +# real QA test starts here
> +_supported_fs generic
> +_supported_os Linux
> +_require_xfs_io_error_injection "iunlink_fallback"
> +_require_scratch
> +
> +rm -f $seqres.full
> +_scratch_mkfs >> $seqres.full 2>&1
> +_scratch_mount
> +
> +# Set ULIMIT_NOFILE to min(file-max, 30000 files per LOAD_FACTOR)
> +# so that this test doesn't take forever or OOM the box
> +max_files=$((30000 * LOAD_FACTOR))
> +max_allowable_files=$(cat /proc/sys/fs/file-max)
> +test $max_files -gt $max_allowable_files && max_files=$max_allowable_files
> +ulimit -n $max_files
> +
> +# Force xfs to use the iunlinked fallback 50% of the time
> +_scratch_inject_error "iunlink_fallback" "2"
> +
> +# Open a lot of unlinked files
> +echo create >> $seqres.full
> +program=$PWD/src/tmpfile
> +(cd $SCRATCH_MNT ; $program >> $seqres.full)
> +
> +# Unmount to prove that we can clean it all
> +echo umount >> $seqres.full
> +before=$(date +%s)
> +_scratch_unmount
> +after=$(date +%s)
> +echo "Unmount took $((after - before))s." >> $seqres.full
> +
> +# Mount so that we can run the usual checks
> +echo silence is golden
> +_scratch_mount
> +status=0
> +exit
> diff --git a/tests/xfs/736.out b/tests/xfs/736.out
> new file mode 100644
> index 00000000..0258a248
> --- /dev/null
> +++ b/tests/xfs/736.out
> @@ -0,0 +1,2 @@
> +QA output created by 736
> +silence is golden
> diff --git a/tests/xfs/737 b/tests/xfs/737
> new file mode 100755
> index 00000000..47e65607
> --- /dev/null
> +++ b/tests/xfs/737
> @@ -0,0 +1,79 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0+
> +# Copyright (c) 2019 Oracle, Inc. All Rights Reserved.
> +#
> +# FS QA Test No. 737
> +#
> +# Stress test creating a lot of unlinked O_TMPFILE files and closing them
> +# all at once, checking that we don't blow up the filesystem. This is sort
> +# of a performance test for the xfs unlinked inode backref patchset, but it
> +# applies to most other filesystems.
> +#
> +# Here we force the use of the slow iunlink bucket walk code, using every
> +# CPU possible.
> +#
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +tmp=/tmp/$$
> +status=1 # failure is the default!
> +testfile=$TEST_DIR/$seq.txt
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> + cd /
> + rm -f $tmp.*
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/attr
> +. ./common/filter
> +. ./common/inject
> +
> +# real QA test starts here
> +_supported_fs generic
> +_supported_os Linux
> +_require_xfs_io_error_injection "iunlink_fallback"
> +_require_scratch
> +
> +rm -f $seqres.full
> +_scratch_mkfs >> $seqres.full 2>&1
> +_scratch_mount
> +
> +# Load up all the CPUs, two threads per CPU.
> +nr_cpus=$(( $(getconf _NPROCESSORS_ONLN) * 2 ))
> +
> +# Set ULIMIT_NOFILE to min(file-max, 30000 files per cpu per LOAD_FACTOR)
> +# so that this test doesn't take forever or OOM the box
> +max_files=$((30000 * LOAD_FACTOR))
> +max_allowable_files=$(( $(cat /proc/sys/fs/file-max) / nr_cpus ))
> +test $max_files -gt $max_allowable_files && max_files=$max_allowable_files
> +ulimit -n $max_files
> +
> +# Force xfs to use the iunlinked fallback 50% of the time
> +_scratch_inject_error "iunlink_fallback" "2"
> +
> +# Open a lot of unlinked files
> +echo create >> $seqres.full
> +program=$PWD/src/tmpfile
> +for i in $(seq 1 $nr_cpus); do
> + (mkdir $SCRATCH_MNT/$i ; cd $SCRATCH_MNT/$i ; $program >> $seqres.full) &
> +done
> +for i in $(seq 1 $nr_cpus); do
> + wait
> +done
> +
> +# Unmount to prove that we can clean it all
> +echo umount >> $seqres.full
> +before=$(date +%s)
> +_scratch_unmount
> +after=$(date +%s)
> +echo "Unmount took $((after - before))s." >> $seqres.full
> +
> +# Mount so that we can run the usual checks
> +echo silence is golden
> +_scratch_mount
> +status=0
> +exit
> diff --git a/tests/xfs/737.out b/tests/xfs/737.out
> new file mode 100644
> index 00000000..bdc4966d
> --- /dev/null
> +++ b/tests/xfs/737.out
> @@ -0,0 +1,2 @@
> +QA output created by 737
> +silence is golden
> diff --git a/tests/xfs/group b/tests/xfs/group
> index 7b7d69f1..d3189cd5 100644
> --- a/tests/xfs/group
> +++ b/tests/xfs/group
> @@ -497,3 +497,5 @@
> 497 dangerous_fuzzers dangerous_scrub dangerous_online_repair
> 498 dangerous_fuzzers dangerous_norepair
> 499 auto quick
> +736 auto quick unlink
> +737 auto quick unlink
>
